Skip to content

General: Fix school names filter for CIT #1739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sachmii wants to merge 7 commits into
base: main
Choose a base branch
from
Open

General: Fix school names filter for CIT #1739

sachmii wants to merge 7 commits into from
+19 −4

Conversation

@sachmii
Copy link
Contributor

@sachmii sachmii commented Jan 20, 2026 •
edited by github-actions bot
Loading

Checklist

General

Server

Motivation and Context

Closes #1640.
Previously, when filtering for CIT in the departments view, the results wouldn't appear only after selecting another school.

Description

  • Manually setting schoolNames in DepartmentResource

Steps for Testing

Prerequisites:

  1. Log in to TumApply as admin
  2. Go to Departments section
  3. Filter for "CIT" and check that results appear

Review Progress

Code Review

  • Code Review 1

Manual Tests

  • Test 1

Test Coverage

Warning: Server tests failed. Coverage could not be fully measured. Please check the workflow logs.

Last updated: 2026-01-23 11:04:29 UTC

Screenshots

image

@sachmii sachmii self-assigned this Jan 20, 2026
@sachmii sachmii requested a review from az108 as a code owner January 20, 2026 09:15
@sachmii sachmii linked an issue Jan 20, 2026 that may be closed by this pull request
CIT school filter not working in departments admin view #1640
Open
@github-actions github-actions bot added server Pull requests that update Java code. (Added Automatically!) user management Code changes in user management module. labels Jan 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

📊 Server Test Coverage Too Low

🔍 View coverage locally:

./gradlew test jacocoTestReport
open build/reports/jacoco/test/html/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-server" artifact from this workflow run.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

🤖 OpenAPI spec and client code auto-updated and committed.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

🤖 No OpenAPI or client changes needed.

@sachmii sachmii requested a review from Bofan-Zhu January 20, 2026 10:44
CelineLahnor
CelineLahnor approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@CelineLahnor CelineLahnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested it on the test server and it looks fine for me. Thank you :)

@sachmii sachmii added ready for merge PR is ready to merge and removed ready for review labels Jan 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

🤖 No OpenAPI or client changes needed.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2026

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

Kiara65
Kiara65 approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@Kiara65 Kiara65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thank you 🥳

az108
az108 requested changes Jan 22, 2026
View reviewed changes
@az108 az108 removed the ready for merge PR is ready to merge label Jan 22, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

🤖 No OpenAPI or client changes needed.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

@sachmii sachmii added the ready for merge PR is ready to merge label Jan 23, 2026
@sachmii sachmii requested a review from az108 January 23, 2026 10:46
@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

🤖 No OpenAPI or client changes needed.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2026

@sachmii Test coverage could not be fully measured because some tests failed. Please check the workflow logs for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CelineLahnor CelineLahnor CelineLahnor approved these changes

@Kiara65 Kiara65 Kiara65 approved these changes

@Bofan-Zhu Bofan-Zhu Awaiting requested review from Bofan-Zhu

@az108 az108 Awaiting requested review from az108 az108 is a code owner

Assignees

@sachmii sachmii

Labels

ready for merge PR is ready to merge server Pull requests that update Java code. (Added Automatically!) user management Code changes in user management module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CIT school filter not working in departments admin view

5 participants

@sachmii @az108 @CelineLahnor @Kiara65